Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] chore: resolve node deprecation warnings in workflows #4081

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[1.x] chore: resolve node deprecation warnings in workflows #4081

merged 4 commits into from
Oct 22, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Oct 19, 2024 •
edited
Loading

@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 19, 2024 17:05
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner October 19, 2024 17:05
@SychO9
Copy link
Member

SychO9 commented Oct 19, 2024

there was also changes made here: 257be2b#diff-8f0cab030414f9e64c7444c9011370f3435c52893686c91babdb72810568b0dc

@DavideIadeluca DavideIadeluca marked this pull request as draft October 19, 2024 17:24
@SychO9
Copy link
Member

SychO9 commented Oct 19, 2024 •
edited
Loading

fyi, also necessary:

@DavideIadeluca DavideIadeluca changed the title [1.x] chore: update frontend workflow [1.x] chore: resolve node deprecation warnings in workflows Oct 19, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 19, 2024 20:51
@DavideIadeluca
Copy link
Contributor Author

fyi, also necessary:

@SychO9 Thanks for debugging this, CI is now also passing here

@imorland imorland requested a review from SychO9 October 21, 2024 19:33
@imorland imorland merged commit 92b2b4a into flarum:1.x Oct 22, 2024
274 checks passed
@imorland imorland deleted the di/workflow-deprecations branch October 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@SychO9 SychO9 Awaiting requested review from SychO9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideIadeluca @SychO9 @imorland